Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMAKE_OSX_DEPLOYMENT_TARGET #4300

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Set CMAKE_OSX_DEPLOYMENT_TARGET #4300

merged 1 commit into from
Nov 2, 2021

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Nov 1, 2021

This version represents that current reality although we
would like to lower this for increased compatibility. See: #4299

This version represents that current reality although we
would like to lower this for increased compatibility. See: #4299
@sbc100 sbc100 requested a review from dschuff November 1, 2021 21:34
@sbc100 sbc100 enabled auto-merge (squash) November 1, 2021 22:17
@dschuff
Copy link
Member

dschuff commented Nov 1, 2021

Before we land this, we should make sure that this option gets properly overidden if set on the command line (since that's exactly what we are currently doing for emscripten-releases).

@sbc100
Copy link
Member Author

sbc100 commented Nov 1, 2021

Before we land this, we should make sure that this option gets properly overidden if set on the command line (since that's exactly what we are currently doing for emscripten-releases).

I'm confident enough that that is how it works... if you want to double check please do but I'm tempted to just land it.

@sbc100
Copy link
Member Author

sbc100 commented Nov 1, 2021

Before we land this, we should make sure that this option gets properly overidden if set on the command line (since that's exactly what we are currently doing for emscripten-releases).

I'm confident enough that that is how it works... if you want to double check please do but I'm tempted to just land it.

See https://cmake.org/cmake/help/latest/command/set.html#set-cache-entry

@sbc100 sbc100 requested a review from tlively November 1, 2021 23:43
@sbc100 sbc100 merged commit e0aacbc into main Nov 2, 2021
@sbc100 sbc100 deleted the set_min_macos_version branch November 2, 2021 00:27
@dschuff
Copy link
Member

dschuff commented Nov 2, 2021

FTR, I checked after the DEPS roll and it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants