[Parser] Allow any number of foldedinsts in foldedinsts
#5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Diff is smaller without whitespace. |
Codecov Report
@@ Coverage Diff @@
## main #5965 +/- ##
==========================================
- Coverage 43.00% 43.00% -0.01%
==========================================
Files 492 492
Lines 74875 74879 +4
Branches 11656 11658 +2
==========================================
+ Hits 32200 32201 +1
- Misses 39450 39452 +2
- Partials 3225 3226 +1
|
kripken
reviewed
Sep 20, 2023
| return false; | ||
| } | ||
| bool ret = takeKeyword(expected); | ||
| lexer = original; |
There was a problem hiding this comment.
Very. It's essentially just resetting an index into the source buffer to its previous value.
Merged
|
See also WebAssembly/spec#1682 |
tlively
force-pushed
the
parser-fix-foldedinsts
branch
from
fdf17e2 to
be155c7
Compare
tlively
force-pushed
the
parser-simplify-instrs
branch
from
a679fee to
fe1a81a
Compare
tlively
force-pushed
the
parser-fix-foldedinsts
branch
from
be155c7 to
65ee4c5
Compare
Somewhat counterintuitively, the text syntax for a folded `if` allows any number of folded instructions in the condition position, not just one. Update the corresponding `foldedinsts` parsing function to parse arbitrary sequences of folded instructions and add a test.
tlively
force-pushed
the
parser-fix-foldedinsts
branch
from
65ee4c5 to
f10684c
Compare
|
I found a much simpler way to implement this. PTAL! |
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…y#5965) Somewhat counterintuitively, the text syntax for a folded `if` allows any number of folded instructions in the condition position, not just one. Update the corresponding `foldedinsts` parsing function to parse arbitrary sequences of folded instructions and add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat counterintuitively, the text syntax for a folded
ifallows any numberof folded instructions in the condition position, not just one. Update the
corresponding
foldedinstsparsing function to parse arbitrary sequences offolded instructions and add a test.