OnceReduction: Optimize bodies of trivial "once" functions #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas Lively <tlively@google.com>
tlively
approved these changes
Oct 30, 2023
|
Logic LGTM, validating on my branch. |
👍 |
|
Great, thanks for confirming @gkdn Meanwhile this has been fuzzed to almost 1M iterations, so I'm fairly confident in it (though this pattern is quite hard to fuzz). |
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…ly#6061) In particular, if the body just calls another "once" function, then we can skip the early-exit logic.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, if the body just calls another "once" function, then we can
skip the early-exit logic (see details in the comment in the new code).
Followup/replacement of #6055
cc @gkdn