[analysis] Simplify the stack lattice #6069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
kripken
approved these changes
Nov 1, 2023
| return NO_RELATION; | ||
| } | ||
| result = GREATER; | ||
| continue; |
There was a problem hiding this comment.
This switch sure looks familiar now... 🤔
There was a problem hiding this comment.
Maaaaybe it makes sense to try to share the switch logic. Note that everything surrounding the switch is slightly different in every case, though. (And in the tuple case, the switch contains recursive calls instead of continues.)
tlively
force-pushed
the
stack-lattice-fixups
branch
from
24bbc38 to
7f56796
Compare
tlively
force-pushed
the
shared-lattice
branch
from
9a4797e to
bb58f6f
Compare
tlively
force-pushed
the
stack-lattice-fixups
branch
from
7f56796 to
456aa3c
Compare
|
I only see one commit, so I'm not sure what changed since I approved this? Skimming it I don't see anything obviously different, and I didn't ask for changes? |
|
The command I used to push and open #6069 must have re-requested review on this. Sorry for the noise! |
tlively
force-pushed
the
stack-lattice-fixups
branch
from
456aa3c to
350ba10
Compare
Remove the ability to represent the top element of the stack lattice since it isn't necessary. Also simplify the element type to be a simple vector, update the lattice method implementations to be more consistent with implementations in other lattices, and make the tests more consistent with the tests for other lattices.
tlively
force-pushed
the
stack-lattice-fixups
branch
from
350ba10 to
838bfac
Compare
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Remove the ability to represent the top element of the stack lattice since it isn't necessary. Also simplify the element type to be a simple vector, update the lattice method implementations to be more consistent with implementations in other lattices, and make the tests more consistent with the tests for other lattices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ability to represent the top element of the stack lattice since it
isn't necessary. Also simplify the element type to be a simple vector, update
the lattice method implementations to be more consistent with implementations in
other lattices, and make the tests more consistent with the tests for other
lattices.