[Parser] Condense redundant pop values #6339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Feb 23, 2024
src/wasm/wasm-ir-builder.cpp
Outdated
| } else { | ||
| return builder.makeTupleMake(values); | ||
| return pop(numValues); |
There was a problem hiding this comment.
This would be nice as a one-liner ternary
ashleynh
force-pushed
the
combined_pop
branch
from
303f952 to
d7310ac
Compare
ashleynh
changed the title
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
A bit of clean-up, changes getBranchValue to use pop().
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of clean-up, changes getBranchValue to use pop().