Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changlog before release [NFC] #6356

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 27, 2024

Also, any thoughts on the timing of a release? I was thinking of doing one before the
end of the week.

@kripken kripken requested review from tlively and aheejin February 27, 2024 16:58
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog LGTM. I think it's plausible that we could switch wasm-opt to the new parser this week. Do you think it would be good to try to get that into the release, or should we save that for the next release?

@kripken
Copy link
Member Author

kripken commented Feb 27, 2024

Exciting about the parser!

Are you aware of people using our builds here that are waiting on that? If so then let's wait for it. If not, then given this release will already be quite big, maybe it would best to separate.

@kripken
Copy link
Member Author

kripken commented Feb 27, 2024

Landing the changelog update but let's keep talking about the timing of a release.

@kripken kripken merged commit f868137 into WebAssembly:main Feb 27, 2024
14 checks passed
@kripken kripken deleted the changes branch February 27, 2024 19:16
@tlively
Copy link
Member

tlively commented Feb 27, 2024

No, nobody is actively waiting for the parser. Leaving it for a follow-on release sgtm, I agree this release already has a bunch of new things in it.

radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants