[wasm2js] Run LLVM nontrapping fptoint lowering when running for emscripten #7116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ripten Lower away saturating fptoint operations when we know we are using emscripten.
|
This is needed to pass some wasm2js tests in Emscripten. The alternative would be to implement full support for nontrapping fp operations in wasm2js, but I don't have a good sense for how much work that would be. |
kripken
reviewed
Nov 26, 2024
| @@ -0,0 +1,564 @@ | |||
| (module | |||
There was a problem hiding this comment.
There should be output files to check in with this, something like FILENAME.2asm.js.*.
But, for a test, maybe add just a minimal file with one fptoint operation? I don't think we need to add coverage for the entire set of instructions, which the pass has tests for. We mainly want to test that the pass runs. Unless there is a benefit I'm missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower away saturating fptoint operations when we know we are using emscripten.