[NFC] Move more logic about unfuzzable tests to a shared location #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Dec 20, 2024
scripts/test/fuzzing.py
Outdated
Comment on lines
80
to
83
| # https://github.com/WebAssembly/binaryen/issues/3203 | ||
| 'simd.wast', | ||
| # corner cases of escaping of names is not interesting | ||
| 'names.wast', |
There was a problem hiding this comment.
It's worth checking whether these two can be re-enabled now.
There was a problem hiding this comment.
Looks like names.wast causes errors,
$ wasm-metadce a.wat -o a.wat --graph-file a.json -all
wasm-metadce: /usr/local/google/home/azakai/Dev/binaryen/src/support/json.h:282: char* json::Value::parse(char*): Assertion `*curr == ','' failed.
Aborted
a.wat can be an empty wasm module. The json file was created from names in names.wast, and I guess we are not escaping something there, or json.h isn't reading escaped names properly.
There was a problem hiding this comment.
That json looks valid, or at least JS engines don't error on it. So json.h parsing might be the problem.
There was a problem hiding this comment.
Probably needs to be updated to handle arbitrary unicode and possibly null characters in the middle of a string.
There was a problem hiding this comment.
simd.wast otoh looks fine, I enabled it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that #7165 was not enough because we had a second (!?)
list of tests to ignore, and also a condition. Move all that to the shared
location as well, continuing that PR.
Also remove
simd.wastfrom the list, as that issue has been fixed.