Fix handling of declarative segments #7660
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declarative segments can be referred to in runtime, but they will be empty. Update handling to create an empty segment, instead of ignoring. Enable `elem.wast` in the spec test suite.
tlively
reviewed
Jun 18, 2025
| ;; CHECK-BIN-NODEBUG: (elem $9 (table $3) (i32.const 0) (ref null $0) (item (ref.func $0)) (item (ref.func $2))) | ||
| ;; CHECK-BIN-NODEBUG: (elem $9 func) | ||
|
|
||
| ;; CHECK-BIN-NODEBUG: (elem $10 (table $3) (i32.const 0) (ref null $0) (item (ref.func $0)) (item (ref.func $2))) |
There was a problem hiding this comment.
It would be good if the binary writer searched for an empty segment with an appropriate type to reuse as the declarative segment to avoid having round trips increase the number of segments like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarative segments can be referred to in runtime, but they will be empty.
Update handling to create an empty segment, instead of ignoring.
Enable
elem.wastin the spec test suite.