[spec] Specify instantiate #114
Conversation
|
@gahaas, PTAL |
document/core/exec/instructions.rst
Outdated
| @@ -890,15 +890,15 @@ Memory Instructions | |||
|
|
|||
| d. Execute the instruction :math:`\MEMORYCOPY`. | |||
|
|
|||
| e. Push the value :math:`\vconst_\I32(dst+1)` to the stack. | |||
| e. Push the value :math:`\vconst_{\I32}(dst+1)` to the stack. | |||
There was a problem hiding this comment.
The style here is inconsistent with e.g. item a in line 885. I don't know which style is the correct one, and if this should be done in this PR, but in the long run I would prefer consistency.
There was a problem hiding this comment.
Do you mean the Latex style? It's a subscript here but not above. Strictly speaking the braces shouldn't be necessary here either, but our DIY macro expansion working around Sphinx limitations requires it.
There was a problem hiding this comment.
I entered the document/core directory and executed make html
Item a reads i32.const, whereas item e reads const_i32 (please imagine a subscript here. Maybe there is a rule in place here that I don't understand.
There was a problem hiding this comment.
Oh, one is syntax, the other a meta function, analogous to t.add vs add_t. Clicking on them should take you to the definitions. They should also appear in different font, although that admittedly isn't all that noticable in the HTML rendering.
There was a problem hiding this comment.
FWIW, we can probably get rid of the meta function again if we adopt #111.
Incorporate active/passive segments into instantiation. While doing so, drop initelem/initdata administrative instructions and express it in terms of table.init and memory.init instructions. Adjust interpreter accordingly.
Baseline is #113. See last commit for new changes.