update tests to match new reentrance rules #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent discussions [^1] regarding optimizing reentrance checks in fused adapters have resulted in a plan to disallow lowering a lift where the lowering instance is an ancestor of the lifting instance or vice-versa. A bunch of tests in `fused.wast` were doing that, so I've updated them to not do that. In addition, I'm about to open a Wasmtime PR to enforce the new rule and subsume existing code that created "degenerate adapter" functions for self-to-self lift/lower pairs. Consequently, I've updated `adapter.wast` to expect a "cannot enter component instance" trap instead of a "degenerate component adapter" one. [^1]: https://bytecodealliance.zulipchat.com/#narrow/channel/217126-wasmtime/topic/Wasmtime.20sync.3C-.3Esync.20adapter.20optimizability
lukewagner
approved these changes
Jan 13, 2026
Member
lukewagner
left a comment
lukewagner
left a comment
There was a problem hiding this comment.
lgtm! (I plan to update #589 soon to match.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent discussions 1 regarding optimizing reentrance checks in fused adapters have resulted in a plan to disallow lowering a lift where the lowering instance is an ancestor of the lifting instance or vice-versa. A bunch of tests in
fused.wastwere doing that, so I've updated them to not do that.In addition, I'm about to open a Wasmtime PR to enforce the new rule and subsume existing code that created "degenerate adapter" functions for self-to-self lift/lower pairs. Consequently, I've updated
adapter.wastto expect a "cannot enter component instance" trap instead of a "degenerate component adapter" one.Footnotes
https://bytecodealliance.zulipchat.com/#narrow/channel/217126-wasmtime/topic/Wasmtime.20sync.3C-.3Esync.20adapter.20optimizability ↩