Adjust unlinkable test in memory_max tests #46
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the import is missing, the "read the imports" step in the JS API will cause a TypeError to be thrown instead of a link error. Changing the condition to an invalid import with the wrong type causes a LinkError to be thrown instead, which allows the use of assert_unlinkable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dummy import used in the test is missing, the first step in "read the imports" in the JS API will cause a TypeError to be thrown when run in a browser implementation. But the test expects a link error instead due to using
assert_unlinkableso the test ends up failing.This PR changes the dummy import in the test so it's an invalid import with the wrong type, which should produce a link error as desired, and lets the test succeed with JS hosts.