Rename dont_need to discard and mention decommit as an option
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * `shmem_create(length)`: create a memory object that can be simultaneously | ||
| shared between multiple linear memories | ||
| * `map_shmem(addr, length, shmem, shmem-offset)`: like `map_file` except | ||
| `MAP_SHARED`, which isn't otherwise valid on read-only Blobs | ||
| * `mprotect(addr, length, prot-flags)`: change protection on the range | ||
| `[addr, addr+length)` (where `addr+length <= memory_size`) | ||
| * `decommit(addr, length)`: equivalent to `mprotect(addr, length, PROT_NONE)` | ||
| followed by `discard(addr, length)` and potentially more efficient than | ||
| performing these operations in sequence. |
There was a problem hiding this comment.
Getting PROT_NONE has a bigger meaning that decommitting IMO. I'm not sure what name would be better... "void" has other meanings.
There was a problem hiding this comment.
I'm not sure what you mean. Are you commenting on the naming of decommit?
There was a problem hiding this comment.
Yeah, but without a better name to suggest I'll lgtm and hope someone else comes up with a nicer name before you commit :-)
There was a problem hiding this comment.
Hah, thanks. As we see here with dont_need=>discard, we can always rename.
lukewagner
added a commit
that referenced
this pull request
Oct 7, 2015
Rename `dont_need` to `discard` and mention `decommit` as an option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #384.