This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Simplify exception dispatch to branches #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposes to use the idea suggested by WebAssembly#58 on using `br_on_exn` instead of `if_except`.
aheejin
commented
Dec 1, 2018
| else | ||
| Instruction* | ||
| ``` | ||
| block $l (result i32 i64) |
There was a problem hiding this comment.
Even though #58 suggested the multi-value proposal is a prerequisite for this and this example also uses a multi-value return block, the multi-value proposal is not necessarily a prerequisite for this exception handling proposal; we can do with a single value yielding blocks until the multi value proposal arrives.
rossberg
approved these changes
Dec 3, 2018
|
Looks good. Thanks! |
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 6, 2020
* Refactor type in passive segments * Make tests more specific
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this pull request
Feb 23, 2021
This proposes to use the idea suggested by WebAssembly#58 on using `br_on_exn` instead of `if_except`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes to use the idea suggested by #58 on using
br_on_exninstead ofif_except.