[js-api] Update the 'read the imports' process #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-commit-queue
pushed a commit
to takikawa/WebKit
that referenced
this pull request
Dec 20, 2023
https://bugs.webkit.org/show_bug.cgi?id=264655 Reviewed by Justin Michaud. The GC proposal JS API was recently updated (WebAssembly/gc#467) to allow direct import of reftype globals in more cases. This patch also includes a version of the pending WPT tests for this case (tracked upstream here: WebAssembly/gc#498) which should be updated later if there are any changes in the accepted upstream version. * JSTests/wasm/gc/js-api.js: (testImport.): (testImport): * LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/gc/global-import.tentative.any.js: Added. (setup.doLink): (setup): (test): * Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h: (JSC::fromJSValue): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::initializeImports): Canonical link: https://commits.webkit.org/272367@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where the global has a reference type. See #461.