New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues in the JS API #78

Merged

sbc100 merged 1 commit into WebAssembly:main from bvisness:js-api-cleanup

Sep 23, 2024

Collaborator

bvisness commented Aug 20, 2024

This PR fixes a few lingering issues in the JS API left over from #75:

IndexValue incorrectly used unsigned long long instead of unsigned long. The current JS API uses [EnforceRange] unsigned long, and the [EnforceRange] behavior must be preserved.
The return type of Memory.grow should have also been updated to IndexValue.
For symmetry with [EnforceRange], IndexValueToU64 should have thrown TypeError for out-of-range BigInt values instead of RangeError.


Fix small issues in the JS API

2fb0812

bvisness mentioned this pull request

Tests needed for recent spec updates #80

Open

sbc100 approved these changes

View reviewed changes

sbc100 merged commit c61da44 into WebAssembly:main

7 checks passed

bvisness deleted the js-api-cleanup branch

October 17, 2024 07:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment