Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "index type" to "address type" across the spec #90

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

bvisness
Copy link
Collaborator

Resolves #67.

Currently draft because I have not yet updated the spec interpreter, but the entire spec (core and JS) should be correct.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment

document/core/valid/types.rst Outdated Show resolved Hide resolved
It is very important that you have precisely the correct number of dots.
It would be too much work for the computer otherwise.
@bvisness bvisness marked this pull request as ready for review October 17, 2024 10:17
@bvisness
Copy link
Collaborator Author

Re-requested review now that the spec interpreter has also been updated.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with perhaps one request: in the interpreter, shorten the type name to addr_type to more closely match the spec's naming.

@bvisness bvisness merged commit 4056ff9 into WebAssembly:main Oct 18, 2024
9 checks passed
@bvisness bvisness mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Index Type to something else, perhaps Offset Type
2 participants