Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

table.fill tests should match new bounds check semantics from bulk-memory proposal #70

Closed
sbc100 opened this issue Dec 24, 2019 · 4 comments

Comments

@sbc100
Copy link
Member

sbc100 commented Dec 24, 2019

Since this change to bulk memory bounds checks are now performed before fill operations:
WebAssembly/bulk-memory-operations#123

However table_fill.wast still includes tests that depend on partial execution of the fill.

@sbc100
Copy link
Member Author

sbc100 commented Dec 24, 2019

With this change I don't think its possible for an implementation to pass both reference-types and bulk-memory tests at the same time.

@rossberg
Copy link
Member

I just looked into this, but AFAICT, it was already up to date, and all the tests in table_fill.wast look fine. Can you point me to which test specifically you think is wrong?

@rossberg
Copy link
Member

Ah, sorry, I think that was fixed recently by my rebase on the bulk proposal. Should be fine now.

@sbc100
Copy link
Member Author

sbc100 commented Jan 14, 2020

Thanks!

rossberg pushed a commit that referenced this issue May 14, 2020
* Remove irrelevant comment

* Support node.js as well
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants