-
Notifications
You must be signed in to change notification settings - Fork 43
Small rename of shuffle and swizzle #316
Comments
You could bring this to the SIMD group, but I'm guessing there won't be much opposition, since changing the name doesn't really affect much. Personally I think we should go ahead and make these changes now. |
v8x16.shuffle and v8x16.swizzle is now i8x16.shuffle and i8x16.swizzle respectively. Fixed WebAssembly#316.
I think this only makes sense in context of the other change you are proposing, otherwise it would not be the last remaining instruction with |
@penzn "bring this up as port of the large rename" do you mean refer to this issue in the issue with the larger rename? Or bring both of these topics out at the next SIMD sync? |
I think we should adopt the larger rename of loads and this one at the same time. I also think we should do another sync, though I doubt there would be much opposition to these changes. |
Got it, in comment#1:
So if that large rename happens, then this will also happen alongside. (If the large rename happens there is even less reason this issue should be dropped.) |
With larger rename happening there is no reason to keep the |
I am in agreement! :) |
v8x16.shuffle and v8x16.swizzle is now i8x16.shuffle and i8x16.swizzle respectively. Fixed WebAssembly#316.
The |
@carlsmith I agree that it's not totally self documenting, but "shuffle" is standard terminology in SIMD ISAs and other SIMD-related work. For example, see clang's portable |
@tlively - Ah, I see. That makes sense then. Sorry. Thanks for the clarification. |
v8x16.shuffle and v8x16.swizzle is now i8x16.shuffle and i8x16.swizzle respectively. Fixed #316.
These instructions previously used prefixes like v8x16 to signify that they were agnostic between float and int interpretations. We renamed these instructions to remove this form of prefix in WebAssembly/simd#297 and WebAssembly/simd#316 and this commit brings the names in LLVM up to date. Differential Revision: https://reviews.llvm.org/D93722
I propose to rename
v8x16.shuffle
andv8x16.swizzle
toi8x16.shuffle
andi8x16.swizzle
, this is a tiny change fromv
prefix, toi
.The purpose of the
v
is to indicate that we are not concerned with the underlying type. The rename does not change this fact. The purpose of the rename is to make the spec slightly simpler, and have less special cases.If #297 happens (likely, given lack of opposition), these 2 instructions will be the only special instructions that begin with
v8x16
. If we can usei8x16.swizzle
andi8x16.shuffle
, it will simplify the specification slightly, since there is no need to talk aboutv8x16
as a syntax.Additionally, the rename will be consistent with other instructions, like the horizontal reductions
i32x4.all_true
, which applies the same if the instruction wasf32x4.all_true
.The text was updated successfully, but these errors were encountered: