-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partially out of bounds store writes to memory #438
Comments
I agree. Please see #439 for a fix. |
Could this also be clarified in the design repo? |
This is now fixed in the spec interpreter and the design repo. |
ngzhian
added a commit
to ngzhian/spec
that referenced
this issue
Nov 4, 2021
…bly#438) These were accepted into the proposal in WebAssembly#376. There are 12 instructions in total: - i16x8.extmul_{low,high}_i8x16_{s,u} - i32x4.extmul_{low,high}_i16x8_{s,u} - i64x2.extmul_{low,high}_i32x4_{s,u} The implementation is straightforward, widen (using existing operations), then a multiply with the wider shape. The binary opcodes are not decided yet, they currently follow the ones used in V8, when those are finalized, we can change it to match. Added a test generation script that reuses some logic in the generator for arithmetic instructions. Since these instructions have different src and dst shapes, I tweaked the base class to allow for having different shapes.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this issue
Oct 3, 2023
List possible implementation limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This testcase:
fails in the spec interpreter. The spec interpreter appears to be storing the first byte of the 2-byte store, before detecting that the second byte is out of bounds and trapping.
Semantics.md in the design repo just says "out of bounds accesses trap", which leaves some room for ambiguity, but my understanding is that stores should trap before storing anything.
The text was updated successfully, but these errors were encountered: