Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: n -> m #886

Closed
Ekleog opened this issue Oct 5, 2018 · 3 comments
Closed

Typo: n -> m #886

Ekleog opened this issue Oct 5, 2018 · 3 comments

Comments

@Ekleog
Copy link

Ekleog commented Oct 5, 2018

In §4.4.7.2, I think the number of values popped then pushed should be m: the number of return values, and not the number of argument values.

Am I correct?

@conrad-watt
Copy link
Contributor

In §4.4.7.2 the n refers to the arity of the current frame F, which is derived from the length of the function return type. You can see in §4.4.7.1 that a frame is constructed with arity m when invoking a function.

It's not the same n as in §4.4.7.1, which does refer to the length of the function arguments.

@Ekleog
Copy link
Author

Ekleog commented Oct 5, 2018

Oh indeed, thanks! well, then suggestion: rename this n to a m, because changing the variable name at paragraph change is confusing, I being an example of its confusingness :)

@binji
Copy link
Member

binji commented Jan 24, 2019

I think changing this case is fine, but this isn't an isolated case -- many places in the spec use the same variable name for different purposes. I'm curious if you found other places in the document where this was confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants