Skip to content

Minor copy edit suggestions #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion document/core/intro/overview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ This language is structured around the following concepts.
**Tables**
A *table* is an array of opaque values of a particular *element type*.
It allows programs to select such values indirectly through a dynamic index operand.
Currently, the only available element type is an untyped function reference.
Currently, the only available element type is an untyped function reference or a reference to an external host value.
Thereby, a program can call functions indirectly through a dynamic index into a table.
For example, this allows emulating function pointers by way of table indices.

Expand Down
2 changes: 1 addition & 1 deletion document/core/syntax/modules.rst
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ The |MSTART| component of a module declares the :ref:`function index <syntax-fun

.. note::
The start function is intended for initializing the state of a module.
The module and its exports are not accessible before this initialization has completed.
The module and its exports are not accessible externally before this initialization has completed.


.. index:: ! export, name, index, function index, table index, memory index, global index, function, table, memory, global, instantiation
Expand Down
2 changes: 1 addition & 1 deletion document/core/valid/instructions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ Parametric Instructions

* The length of :math:`t^\ast` must be :math:`1`.

* Then the instruction is valid with type :math:`[t^\ast~t^\ast~\I32] \to [t^\ast]`.
* The instruction is valid with type :math:`[t^\ast~t^\ast~\I32] \to [t^\ast]`.

* Else:

Expand Down
3 changes: 1 addition & 2 deletions document/core/valid/types.rst
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ Import Subtyping

When :ref:`instantiating <exec-module>` a module,
:ref:`external values <syntax-externval>` must be provided whose :ref:`types <valid-externval>` are *matched* against the respective :ref:`external types <syntax-externtype>` classifying each import.
In some cases, this allows for a simple form of subtyping, as defined here.
In some cases, this allows for a simple form of subtyping (written ":math:`\matchesexterntype`" formally), as defined here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In some cases, this allows for a simple form of subtyping (written ":math:`\matchesexterntype`" formally), as defined here.
In some cases, this allows for a simple form of subtyping (written ":math:`\matches`" formally), as defined here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, scratch that, that only works on a later repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I tried it and it doesn’t work, which is why I went for this one 😅



.. index:: limits
Expand Down Expand Up @@ -279,7 +279,6 @@ Limits
\vdashlimitsmatch \{ \LMIN~n_1, \LMAX~m_1 \} \matcheslimits \{ \LMIN~n_2, \LMAX~m_2 \}
}


.. _match-externtype:

.. index:: function type
Expand Down