Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename administrative instruction Handle to Prompt. #108

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Rename administrative instruction Handle to Prompt. #108

merged 1 commit into from
Jan 16, 2025

Conversation

dhil
Copy link
Member

@dhil dhil commented Jan 15, 2025

This patch renames Handle to Prompt (differentiating it better from Handler).

@dhil
Rename administrative instruction Handle to Prompt.
1fc2044 
This patch renames `Handle` to `Prompt` (better differentiating it
from `Handler`).
@dhil dhil requested a review from rossberg January 15, 2025 13:39
rossberg
rossberg approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if we should also rename handle_table accordingly, but I can't think of a good name.

@dhil
Copy link
Member Author

dhil commented Jan 15, 2025

Thanks! I wonder if we should also rename handle_table accordingly, but I can't think of a good name.

In wasmtime I actually call it resume_table.

@dhil dhil merged commit fbb55e6 into WebAssembly:main Jan 16, 2025
1 check passed
@dhil dhil deleted the prompt branch January 16, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhil @rossberg