[Overview] Change wake to use unsigned semantics #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a note that we expect engines to trap when there are 4 billion waiters. See issue #108.
aheejin
approved these changes
Nov 15, 2018
aheejin
reviewed
Nov 15, 2018
proposals/threads/Overview.md
Outdated
| | `wake count` > 0 | Wake min(`wake count`, `num waiters`) waiters | | ||
| unsigned `i32`. The operation will wake as many waiters as are waiting on the | ||
| same effective address, up to the maximum as specified by `wake count`. The | ||
| operator returns the number of waiters that were woken as an `i32`. |
llvm-git-migration
pushed a commit
to llvm-git-prototype/llvm
that referenced
this pull request
Nov 16, 2018
Summary: We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wake count. Corresponding spec change: WebAssembly/threads#110 Reviewers: sbc100 Subscribers: dschuff, jgravelle-google, sunfish, jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D54572 llvm-svn=347005
bogner
pushed a commit
to bogner/llvm-zipper-prototype
that referenced
this pull request
Nov 16, 2018
Summary: We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wake count. Corresponding spec change: WebAssembly/threads#110 Reviewers: sbc100 Subscribers: dschuff, jgravelle-google, sunfish, jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D54572 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@347005 91177308-0d34-0410-b5e6-96231b3b80d8
spurious
pushed a commit
to spurious/clang-mirror
that referenced
this pull request
Nov 16, 2018
Summary: We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wake count. Corresponding spec change: WebAssembly/threads#110 Reviewers: sbc100 Subscribers: dschuff, jgravelle-google, sunfish, jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D54572 git-svn-id: http://llvm.org/svn/llvm-project/cfe/trunk@347005 91177308-0d34-0410-b5e6-96231b3b80d8
dylanmckay
pushed a commit
to dylanmckay/clang
that referenced
this pull request
Jan 18, 2019
Summary: We discussed this at the Nov 12th CG meeting, and decided to use the unsigned semantics for the wake count. Corresponding spec change: WebAssembly/threads#110 Reviewers: sbc100 Subscribers: dschuff, jgravelle-google, sunfish, jfb, cfe-commits Differential Revision: https://reviews.llvm.org/D54572 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@347005 91177308-0d34-0410-b5e6-96231b3b80d8
conrad-watt
added a commit
that referenced
this pull request
Dec 14, 2021
ref: WebAssembly/binaryen#4393 In #110 we changed the `count` argument of `atomic.notify` so that it is treated as an unsigned `i32`. Previous to this change, it was interpreted as a signed `i32`, with negative numbers signalling that all threads should be woken. This part of the overview wasn't fully updated - fixing this now.
This was referenced Dec 14, 2021
conrad-watt
added a commit
that referenced
this pull request
Dec 14, 2021
In #110 we changed the `count` argument of `atomic.notify` so that it is treated as an unsigned `i32`. Previous to this change, it was interpreted as a signed `i32`, with negative numbers signalling that all threads should be woken. This part of the overview wasn't fully updated - fixing this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a note that we expect engines to trap when there are 4 billion
waiters.
See issue #108.