Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime-path to DynamicLinking.md #246

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Add runtime-path to DynamicLinking.md #246

merged 3 commits into from
Feb 10, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Feb 6, 2025 •
edited
Loading

Changes to the conventions for #244.

cc @ryanking13 @sbc100.

@hoodmane hoodmane mentioned this pull request Feb 6, 2025
Merged
sbc100
sbc100 reviewed Feb 6, 2025
View reviewed changes
sbc100
sbc100 reviewed Feb 6, 2025
View reviewed changes
@hoodmane
Copy link
Contributor Author

hoodmane commented Feb 7, 2025

@sbc100 are there other people I should ask to review this?

@sunfishcode
Copy link
Member

I wonder of @dicej has any thoughts here, from the perspective of componentize-py.

@hoodmane
Copy link
Contributor Author

hoodmane commented Feb 7, 2025

This is important for truly-at-runtime dynamic linking, but I'd think not really necessary for "componentize" dynamic linking. Maybe if there is an "install" step before componentizing it could be easier to use the rpath, but nothing that couldn't be managed by patching around the build scripts a bit. But I agree it'd be interesting to hear @dicej's opinion.

sbc100
sbc100 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments from others.

Adding @dschuff too

@dicej
Copy link

dicej commented Feb 10, 2025

This is important for truly-at-runtime dynamic linking, but I'd think not really necessary for "componentize" dynamic linking. Maybe if there is an "install" step before componentizing it could be easier to use the rpath, but nothing that couldn't be managed by patching around the build scripts a bit. But I agree it'd be interesting to hear @dicej's opinion.

Yeah, I'm not sure how componentize-py would use this offhand, although maybe it could help with finding needed .so files at component build time. I've got no objections to this PR, in any case.

@sbc100 sbc100 merged commit 4487bbc into WebAssembly:main Feb 10, 2025
sbc100 pushed a commit to llvm/llvm-project that referenced this pull request Feb 24, 2025
@hoodmane
[object][WebAssembly] Add support for RUNTIME_PATH to yaml2obj and ob…
cc7f22e 
…j2yaml (#126080)

This is the first step of adding RPATH support for wasm. 

See corresponding update to the WebAssembly/tool-conventions repo on dynamic
linking: WebAssembly/tool-conventions#246
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Feb 24, 2025
@hoodmane @github-actions
Automerge: [object][WebAssembly] Add support for RUNTIME_PATH to yaml…
cff1a09 
…2obj and obj2yaml (#126080)

This is the first step of adding RPATH support for wasm.

See corresponding update to the WebAssembly/tool-conventions repo on dynamic
linking: WebAssembly/tool-conventions#246
@hoodmane hoodmane mentioned this pull request Feb 27, 2025
Merged
hoodmane added a commit to hoodmane/llvm-project that referenced this pull request Feb 27, 2025
@hoodmane
[lld][WebAssembly] Add RUNTIME_PATH support to wasm-ld
7d79835 
This finishes adding RPATH support for WebAssembly.

See my previous PR which added RPATH support to yaml2obj and obj2yaml:
llvm#126080
See corresponding update to the WebAssembly/tool-conventions repo on dynamic
linking: WebAssembly/tool-conventions#246
sbc100 pushed a commit to llvm/llvm-project that referenced this pull request Feb 28, 2025
@hoodmane
[lld][WebAssembly] Add RUNTIME_PATH support to wasm-ld (#129050)
80ea31c 
This finishes adding RPATH support for WebAssembly.

See my previous PR which added RPATH support to yaml2obj and obj2yaml:
#126080
See corresponding update to the WebAssembly/tool-conventions repo on
dynamic linking:
WebAssembly/tool-conventions#246
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Feb 28, 2025
@hoodmane @github-actions
Automerge: [lld][WebAssembly] Add RUNTIME_PATH support to wasm-ld (#1…
ffa02c2 
…29050)

This finishes adding RPATH support for WebAssembly.

See my previous PR which added RPATH support to yaml2obj and obj2yaml:
llvm/llvm-project#126080
See corresponding update to the WebAssembly/tool-conventions repo on
dynamic linking:
WebAssembly/tool-conventions#246
This was referenced Mar 2, 2025
Merged
Merged
hoodmane pushed a commit to emscripten-core/emscripten that referenced this pull request Mar 6, 2025
@ryanking13
Enable -rpath flag (#23805)
28051fb 
Updates `webassembly.py` to parse and store `WASM_DYLINK_RUNTIME_PATH`
that were suggested in:
WebAssembly/tool-conventions#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

@dschuff dschuff dschuff left review comments

@ryanking13 ryanking13 ryanking13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hoodmane @sunfishcode @dicej @sbc100 @dschuff @ryanking13