Allow binary reader to skip function bodies. NFC #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is purely a performance optimization for wasm-objdump since it doesn't always need to decode function bodies. For a very large wasm file that I was testing this takes the time taken for `wasm-objdump -h` from 8.6s to 1.5s.
dschuff
reviewed
Mar 23, 2022
| @@ -13,12 +12,5 @@ section(CODE) { | |||
| } | |||
| (;; STDERR ;;; | |||
| 000001a: error: unexpected opcode: 0xfe 0x7f | |||
| 000001a: error: unexpected opcode: 0xfe 0x7f | |||
There was a problem hiding this comment.
why is this output duplicated? And, don't we want the same output as we had before, for any behavior that depends on the function contents?
There was a problem hiding this comment.
I changed the type of the test from run-objdump-gen-wasm to run-gen-wasm-bad. The latter is designed specifically for this type of test where we are testing for a binary parse error.
The error occurs twice in all the run-gen-wasm-bad tests, they all of the duplication like this. I think its because run-gen-wasm-bad runs two different tools under the hood: wasm-validate and wasm2wat, and checks that they both fail.
dschuff
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a performance optimization for wasm-objdump since it
doesn't always need to decode function bodies.
For a very large wasm file that I was testing this takes the time taken
for
wasm-objdump -hfrom 8.6s to 1.5s.