src/leb128.cc: fix detection of too-big u64 LEB128s #2256
Conversation
| @@ -0,0 +1,25 @@ | |||
| ;;; TOOL: run-interp-spec | |||
| ;;; ARGS: --enable-memory64 | |||
There was a problem hiding this comment.
Can we write this test without depending on --enable-memory64.
How about just a simple i64.const instruction?
Also, I guess this points to gap in the spec tests?
There was a problem hiding this comment.
Can we write this test without depending on --enable-memory64
Unfortunately not, because the bug was in ReadU64Leb128. :-( Those are only used by memory64 (for memory min, memory max, and load/store offset -- but the first two are in units of pages, so limited to 2^48 anyway). The const literals are using signed Leb128s, e.g. ReadS64Leb128.
There was a problem hiding this comment.
Let me try to submit this to the memory64 proposal repo...
There was a problem hiding this comment.
OK.. maybe add a comment to that effect.
There was a problem hiding this comment.
Submitted PR here: WebAssembly/memory64#38
There was a problem hiding this comment.
OK.. maybe add a comment to that effect.
Done.
Fixes #2192