Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wasm-opcodecnt to wasm-stats #2298

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Rename wasm-opcodecnt to wasm-stats #2298

merged 1 commit into from
Sep 19, 2023

Conversation

SoniEx2
Copy link
Contributor

@SoniEx2 SoniEx2 commented Sep 16, 2023

This is a breaking change. Also uh, sorry, how do you re-generate the man pages and HTML docs?

(also shoutout to 61c910b#diff-cd45c62ec9442a1431d03057a70247b778e5dde436cc7ae4c412d5f0e989cdeeR71 for long time typo!)

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with the man page update

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Sep 18, 2023

alright, uh... how do you do that? we see there's a help2man.lua but we're not really sure how it's supposed to be used... it doesn't seem to have documentation.

(also we don't know how to manually write/update man pages, either)

sorry

@sbc100
Copy link
Member

sbc100 commented Sep 18, 2023

alright, uh... how do you do that? we see there's a help2man.lua but we're not really sure how it's supposed to be used... it doesn't seem to have documentation.

(also we don't know how to manually write/update man pages, either)

sorry

I'm afraid I don't know either. That stuff was written by @binji who is no longer actively involved. He may remember and reply here, but failing that you might need to dive in and figure it out.

@binji
Copy link
Member

binji commented Sep 18, 2023

I don't think I added this, it was an external contributor. So unfortunately, I don't really know how it was meant to be updated either.

@sbc100
Copy link
Member

sbc100 commented Sep 18, 2023

Looking at the commit message it looks like you use it like this:

wabt-tool --help | lua help2man.lau

See #2004

@sbc100
Copy link
Member

sbc100 commented Sep 18, 2023

Looking at the commit message it looks like you use it like this:

wabt-tool --help | lua help2man.lau

See #2004

(You could also just rename the existing man page and search and replace the name)

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Sep 19, 2023

tech debt aside, this should be good to go

@sbc100 sbc100 merged commit dddc03d into WebAssembly:main Sep 19, 2023
15 checks passed
@SoniEx2 SoniEx2 mentioned this pull request Oct 8, 2023
@keithw keithw mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants