fix: null-defer about data and elem in wasm-interp #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Jun 27, 2024
src/interp/interp.cc
Outdated
| StringPrintf("out of bounds data access: access at %u " | ||
| ">= max value %" PRIu64, | ||
| instr.imm_u32x2.snd, | ||
| inst_->datas().size())); |
There was a problem hiding this comment.
Shouldn't validation make this impossible?
There was a problem hiding this comment.
I'm not sure the interpreter should be enforcing constraints that the validator should have already enforced... otherwise we will end up duplicating all the validation rules here.
There was a problem hiding this comment.
There are some formatting issue in the CI log, so I have chosen to use %zu to format vector's size correctly.
tianstcht
force-pushed
the
main
branch
2 times, most recently
from
f92f7fb
to
16431b9
Compare
|
checking the sizes is okay but it's the wrong approach: the module in #2431 should fail validation, it's missing a data section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some null-defer case about data and elem.