-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add ubuntu-24.04-arm regular CI and release artifact #2558
base: main
Are you sure you want to change the base?
Conversation
@@ -30,7 +30,7 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, macos-13, macos-latest, windows-latest] | |||
os: [ubuntu-latest, ubuntu-24.04-arm, macos-13, macos-latest, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its kind of unfortunate that this is called -arm
and not -arm64
or -aarch64
(which are the two names by which I know this architecture).
Perhaps we can avoid directly using the OS names in artifact names?
For example, can we map ubuntu-20.04
to linux-x64
and ubuntu-24.04-arm
to linux-arm64`?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can't say I understand the naming that GitHub went with. The only thing that might make sense sense is that since these images are "partner images" from some contract they have with ARM Ltd., it was named by a program manager? From a developer standpoint it should really be -arm64 or -aarch64. I'll see if I can come up with a not-awful mapping in the action's yml.
Oh that's fun. Looks like there's a gcc-13 ICE in the arm64 build. That something y'all want to report or should I spin up an arm64 box to do it myself?
|
[macos-14]="macos-14", | ||
[windows-latest]="windows-x64", | ||
[wasi]="wasi", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never actually used declare
before. Looks powerful, and scary :)
declare -A OSNAME=( | ||
[ubuntu-20.04]="linux-x64", | ||
[ubuntu-24.04-arm]="linux-arm64", | ||
[macos-14]="macos-14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just drop the -14
and use -x64
here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't macos-14 an arm64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know .. if its is then we should call this -macos-arm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there not still an x86 macos runner available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not since macos-14, aside from large runners (which don't really count since you can't use them for free)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this -macos-arm64
then?
I guess that means that x86_64 macos users don't get pre-compiled releases?
Fixes #2533
the arm64 artifact will be called
wabt-$VERSION-ubuntu-24.04-arm.tar.gz
without any changes to the release-archive action.