Fix wasm2c on windows (via MSVC) #909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `min`/`max` are defined in windows headers, so avoid using them as
symbol names.
* Don't write 0-sized variable definitions; MSVC doesn't like them.
* Prefix all functions with `WASM_RT_CC` to allow specifying a calling
convention. On MSVC this is always `__vectorcall`, to prevent the
optimizer from using the x87 stack for passing floats and doubles.
* Cast the load/store offset to `u64` before adding it to the address.
* MSVC doesn't have `__builtin_expect`, so just ignore it.
* Copy MSVC implementations of i{32,64}.{clz,ctz,popcount} from
config.h.in
* Write 32-bit float constants with 10 digits of precision instead of 9.
For some reason MSVC says that `3.40282347e+38f` is too big, but
`3.402823466e+38f` is OK.
* Refactor `run-spec-wasm2c.py` a bit to pass different command-line
flags when running as MSVC. The `--msvc` flag enables this new
behavior.
* MSVC doesn't have `__attribute__((noreturn))` but instead has
`__declspec(noreturn)`.
* Forward `--msvc` flag through `run-tests.py` to `run-spec-wasm2c.py` * Wrap some long lines * Some python2 vs python3 fixes * Default compiler with `--msvc` flag is `cl`
* Avoid undefined behavior w/ isalpha/isalnum * Track call stack size (not just call stack depth) when trying to determine call stack exhaustion
binji
force-pushed
the
wasm2c-windows
branch
from
2e815a9 to
6632167
Compare
jaykrell
reviewed
Nov 5, 2019
| static inline unsigned long HighDword(unsigned __int64 value) { | ||
| unsigned long high; | ||
| memcpy(&high, (unsigned char*)&value + sizeof(high), sizeof(high)); | ||
| return high; |
There was a problem hiding this comment.
True, I copied this from config.h.in, but I'm not sure why I wrote it this way. :-)
jaykrell
reviewed
Nov 5, 2019
| t2 result; \ | ||
| memcpy(&result, &x, sizeof(result)); \ | ||
| return result; \ | ||
| #define DEFINE_REINTERPRET(name, t1, t2) \ |
There was a problem hiding this comment.
There was a problem hiding this comment.
Good point, though I'd rather get this working and landed before optimizing. It still isn't quite there, unfortunately. It's pretty hard for me to test, since I don't normally run windows.
|
Done in #1843. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.