Fix environment variable init to exit successfully. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
added a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Jan 14, 2020
This adds basic support for environment variables to the test harness, and adds a simple test. This tests the bug found in WebAssembly/wasi-libc#159.
|
Woah.. did we ship this is version wasi-sdk already? I guess that means that basic test we have there don't cover this ? |
sbc100
approved these changes
Jan 14, 2020
|
Yeah, we didn't previously have any tests that set environment variables. I've now opened WebAssembly/wasi-sdk#95 to add such a test. |
sunfishcode
added a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Jan 14, 2020
This adds basic support for environment variables to the test harness, and adds a simple test. This tests the bug found in WebAssembly/wasi-libc#159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bytecodealliance/wasmtime#783.