Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Makefile for LLVM trunk (16) as of 2023-01-05 #379

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Adjust Makefile for LLVM trunk (16) as of 2023-01-05 #379

merged 1 commit into from
Jan 10, 2023

Conversation

glandium
Copy link
Contributor

llvm/llvm-project@d227c3b added __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.

sbc100
sbc100 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably go through and remove some of the older filters here (assuming we aren't trying to support very old versions of llvm).

lgtm to this though

@glandium
Copy link
Contributor Author

I guess the main question would be: what would be the new baseline version? (CI tests LLVM 10, for instance, but the hacks go back to at least version 8).
Anyways, could you merge this?

@sunfishcode sunfishcode merged commit 16a6940 into WebAssembly:main Jan 10, 2023
@sunfishcode
Copy link
Member

We almost certainly don't support building wasi-libc with LLVM 8 or 9 anymore; if someone wanted to remove the hacks, that'd be great!

@cuviper cuviper mentioned this pull request Jan 13, 2023
Merged
john-sharratt pushed a commit to john-sharratt/wasix-libc that referenced this pull request Mar 6, 2023
@glandium @john-sharratt
Adjust Makefile for LLVM trunk (16) as of 2023-01-05 (WebAssembly#379)
ed8b2a2 
llvm/llvm-project@d227c3b
added __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.
bob-beck pushed a commit to openbsd/ports that referenced this pull request Dec 7, 2023
@landryb
lang/wasi-libc: update to git HEAD to support llvm 16
3997b1a 
switch to build with ports-clang 16, cf for llvm support:
- WebAssembly/wasi-libc#379
- WebAssembly/wasi-libc#285
- WebAssembly/wasi-libc#344
adapt a regex to deal with our egrep syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glandium @sunfishcode @sbc100