Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add Ubuntu arm Github runner #568

Merged
merged 13 commits into from
Feb 3, 2025

Conversation

mcbarton
Copy link
Contributor

@mcbarton mcbarton commented Feb 2, 2025

This PR adds the recently generally available Ubuntu arm Github runners to the ci.

@mcbarton mcbarton marked this pull request as draft February 2, 2025 20:03
@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 2, 2025

Set to draft until I can work out how to get libtinfo5 on Ubuntu 24.04 arm. Will debug in a vm locally.

@mcbarton mcbarton force-pushed the Add-Ubuntu-arm-runners-to-the-ci branch from 79834cb to a7a81e0 Compare February 3, 2025 20:20
@mcbarton
Copy link
Contributor Author

mcbarton commented Feb 3, 2025

@sbc100 @alexcrichton Before I look into the failing tests, can you both take a look, and see if there is an easy fix? I've changed the PR so that it is editable by maintainers.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@sbc100
Copy link
Member

sbc100 commented Feb 3, 2025

Looks like the problem is likely wrong version of wasmtime being downloaded: Saving to: ‘build/download/wasmtime-v26.0.1-x86_64-linux.tar.xz’.

test/Makefile Outdated Show resolved Hide resolved
@mcbarton mcbarton marked this pull request as ready for review February 3, 2025 21:11
test/Makefile Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@mcbarton mcbarton requested a review from sbc100 February 3, 2025 21:35
.github/workflows/main.yml Outdated Show resolved Hide resolved
@sbc100 sbc100 changed the title Add Ubuntu arm Github runners to the ci [ci] Add Ubuntu arm Github runner Feb 3, 2025
@sbc100 sbc100 merged commit abe6062 into WebAssembly:main Feb 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants