Add __wasi_sdk_{major,version}__ defines
#709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the generated `wasi/version.h` file with two new `#define`s: * `__wasi_sdk_major__` set to `29` for example for `wasi-sdk-29.0` * `__wasi_sdk_version__` set to `"29.0"` for example for `wasi-sdk-29.0` This'll get set when building wasi-sdk itself through `-DWASI_SDK_VERSION=...` as part of the configuration of libc itself. cc WebAssembly#688
pchickey
approved these changes
Jan 7, 2026
alexcrichton
added a commit
to alexcrichton/wasi-sdk
that referenced
this pull request
Jan 9, 2026
This updates to include WebAssembly/wasi-libc#709 and then additionally configures wasi-libc with `-DWASI_SDK_VERSION=...` to ensure that wasi-sdk builds will now have `__wasi_sdk_major__` defined along with `__wasi_sdk_version__`. Closes WebAssembly/wasi-libc#688
alexcrichton
added a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Jan 9, 2026
This updates to include WebAssembly/wasi-libc#709 and then additionally configures wasi-libc with `-DWASI_SDK_VERSION=...` to ensure that wasi-sdk builds will now have `__wasi_sdk_major__` defined along with `__wasi_sdk_version__`. Closes WebAssembly/wasi-libc#688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the generated
wasi/version.hfile with two new#defines:__wasi_sdk_major__set to29for example forwasi-sdk-29.0__wasi_sdk_version__set to"29.0"for example forwasi-sdk-29.0This'll get set when building wasi-sdk itself through
-DWASI_SDK_VERSION=...as part of the configuration of libc itself.cc #688