Residence proposal #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
commented
Apr 29, 2024
|
|
||
| // Move the tensor to a different device. This operation may result in an expensive data | ||
| // copy. | ||
| move-to: func(device: device) -> result<tensor, error>; |
There was a problem hiding this comment.
@mtr's suggestion: rename to copy-to since that more accurately reflects the semantics here.
There was a problem hiding this comment.
@mingqiusun suggests to.
|
This change is probably not desirable if we adopt #74: if a user can't change where a model resides any more, they shouldn't be allowed to change where a tensor resides. |
|
Is this also implying that tensors in pipelines that cross hardware boundaries will automatically be moved around at compute time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges together some of #69 with various discussions we've had in the ML working group.