Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION file missing from WASI SDK 24 #471

Closed
SingleAccretion opened this issue Aug 6, 2024 · 2 comments · Fixed by #473
Closed

VERSION file missing from WASI SDK 24 #471

SingleAccretion opened this issue Aug 6, 2024 · 2 comments · Fixed by #473

Comments

@SingleAccretion
Copy link
Contributor

I downloaded wasi-sdk-24.0-x86_64-windows.tar.gz from the 24's release artifacts, and the VERSION file that was there in 22 is missing, which does not look right.

@SingleAccretion SingleAccretion changed the title VERSION file missing from 24 VERSION file missing from WASI SDK 24 Aug 6, 2024
@abrown
Copy link
Collaborator

abrown commented Aug 6, 2024

Some initial findings:

  • the new CMake build (from Rewrite the build system with CMake #429) should be trying to build the VERSION file (here)
  • it isn't, even for the released Linux artifacts (this is not just a Windows issue)
  • when I build this locally using ci/build.sh, the VERSION file does actually appear in build/install
  • but VERSION does not appear in build/dist so I think CI is not picking it with the upload-artifact artifact action (confirmed: it is not present in the downloaded dist-x86_64-linux.zip from GitHub actions)
  • once we do fix the copying to build/dist, do we need to update ci/merge-artifacts.sh to make sure it gets merged into the final *.tar file? (Alternately, we could stuff VERSION into one of the component *.tars).

@alexcrichton
Copy link
Collaborator

Ah yes my mistake! Can confirm that VERSION is only in the install and not in the tarballs. I do believe that merge-artifacts.sh will need to be updated to copy it from one tarball to another. I can work on this when I get back next week if no one else solves it in the meantime.

alexcrichton added a commit to alexcrichton/wasi-sdk that referenced this issue Aug 9, 2024
Make sure it makes its way into the sysroot tarball and then copy it
from the sysroot location to the top of the sdk tarball as well.

Closes WebAssembly#471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants