Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest wasi-libc (NFC) #113

Merged
merged 2 commits into from
Apr 2, 2020
Merged

latest wasi-libc (NFC) #113

merged 2 commits into from
Apr 2, 2020

Conversation

pchickey
Copy link
Collaborator

@pchickey pchickey commented Apr 2, 2020

Readme changes, and the latest wasi repo
WebAssembly/wasi-libc#191

@pchickey pchickey changed the title latest wasi-libc (NFC readme changes) latest wasi-libc (NFC) Apr 2, 2020
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. nice use of nested branch names use / is a separator. I've not seen that before. I like it. Would be nice of the tools help enforce that so we could all work in the same repo but with our own branch namespace automatically.

@pchickey pchickey merged commit 0cb1af8 into master Apr 2, 2020
@pchickey pchickey deleted the pch/prep_release_9 branch April 2, 2020 22:59
@pchickey
Copy link
Collaborator Author

pchickey commented Apr 2, 2020

I'm not sure where I picked up the habit but it seems to be standard at my current gig and the prior one. I'm also surprised theres not tool support for it.

kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
* Tidy up some #include names.

* Move non-cloudlibc sources out of the cloudlibc directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants