Add a testcase for getentropy #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedisct1
reviewed
Jan 16, 2021
|
|
||
| int sum = 0; | ||
| for (int i = 0; i < 256; i++) { | ||
| sum += buf[i]; |
There was a problem hiding this comment.
Maybe use unsigned types and ^= instead of += to check for constant output (instead of specifically 0 output).
|
Is the CI here broken? appears that it fails on checkout. |
abrown
force-pushed
the
add-getentropy-test
branch
from
381e4f2
to
4efaa5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic testcase for
getentropywhich checks for errno and a sane result.