Use msys2 clang toolchain to build windows distribution #265
Conversation
TerrorJack
force-pushed
the
main
branch
2 times, most recently
from
ef17238 to
43f5e93
Compare
These dependencies are not needed in wasi-sdk, and if they're enabled, the msys2 dll depenndencies will leak into build products. Also statically links libstdc++, required for the windows build.
|
@sunfishcode Ready for review. |
|
Does the switch from windows-2019 to windows-latest (which is windows-2022) mean that we lose any support or older Windows versions in our distributed artifacts? |
The binaries will run fine on Windows 10 and later versions that ships ucrt in system32. If you wish I can also switch the build platform to windows-2019, though it doesn't provide any meaningful assurance in compatability, since the build process does not use systemwide visual studio installation at all. |
|
I just started a Windows 7 SP1 x64 virtual machine, and the new artifacts work there as long as ucrt is installed. I believe that's a reasonable lowest bound on supported Windows versions. And this is not a regression from the old msvc-produced artifacts, those also require ucrt to be manually installed (and additionally msvcp140). |
|
Great, thanks for investigating that! I think we can switch to this for our next release, which I'm hoping to put out soon. |
Closes #264.
Note: still a WIP, will undraft and ping for review after:
make checkwon't serve this purpose since it needs to be run in a msys2 shell, for now I believeclang --versionandwasm-ld --versionshould suffice since they are the largest executables anyway.