Only push docker image on push or tag #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
force-pushed
the
dockerpush-onlymain
branch
from
491171a to
f5045f8
Compare
sbc100
approved these changes
Jan 13, 2023
anuraaga
force-pushed
the
dockerpush-onlymain
branch
from
f5045f8 to
801f019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed workflows are manually run pretty often on non-main branch like this one, which is populating github packages with the WIP code.
https://github.com/WebAssembly/wasi-sdk/actions/runs/3895139484
Presumably it's fine to not push the docker image on a manual run anyways, alternatively I could filter on ref_type != tag && ref_name == main if that seems better.