Update wasi-libc to latest HEAD #290
Conversation
This pulls in a variety of changes, many of them related to enabling threads in wasi-libc. There may be more changes necessary before releasing a prelease version of wasi-sdk that supports the new `wasm32-wasi-threads` target, but this should get the majority of them.
|
@yamt, @loganek, @sbc100, others: any other wasi-libc PRs that you would like to see merged before a wasi-sdk prerelease is created. Here is the list open PRs: https://github.com/WebAssembly/wasi-libc/pulls. My suggestions (at least to discuss--open to rejecting as well): WebAssembly/wasi-libc#324, WebAssembly/wasi-libc#383. |
|
@abrown I still think we should merge WebAssembly/wasi-libc#324 (already resolved conflicts) but if anybody have a strong opinion about that, we can continue the discussion and postpone it. |
|
Merged WebAssembly/wasi-libc#324; any other opinions on WebAssembly/wasi-libc#383? It's similar in that it is an "enable weird features to support compatibility" change; wasi-libc does not have much to say about priority inheritance but that PR makes it appear as if it works. |
as i commented in the PR, i feel it isn't ready even as an "just ignore the request saying ok" implementation. let's skip it for the prerelease. |
|
Ok, I closed WebAssembly/wasi-libc#383 and updated this PR with the now-merged WebAssembly/wasi-libc#324. After this PR merges, we should be ready for a wasi-sdk + threads prerelease. |
do we plan to have a "official" prerelease in https://github.com/WebAssembly/wasi-sdk/releases ? |
This pulls in a variety of changes, many of them related to enabling threads in wasi-libc. There may be more changes necessary before releasing a prelease version of wasi-sdk that supports the new
wasm32-wasi-threadstarget, but this should get the majority of them.