Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release wasi-sdk-20+threads #296

Closed
wants to merge 4 commits into from
Closed

Pre-release wasi-sdk-20+threads #296

wants to merge 4 commits into from

Conversation

abrown
Copy link
Collaborator

@abrown abrown commented Feb 14, 2023

DO NOT MERGE!

This PR is meant as a visual reminder of how the wasi-sdk-20+threads pre-release was created. This branch includes changes to:

  • update the LLVM source code to v16.0.0-rc2
  • update the wasi-libc source code to its latest HEAD
  • fix an issue with the major version used in the wasi-sdk path
  • and handle some additional kinds of string (e.g., +threads) in the wasi-sdk version tags

Of these, the last change (the additional version.sh strings) can certainly be dropped for a future release of wasi-sdk-20 and the source code bumps likely need to be to even later commits. This PR may be useful, however, as a record of what was was done for wasi-sdk-20+threads.

cc: @sunfishcode, @sbc100

This brings in two recent commits, WebAssembly/wasi-libc#388 and
WebAssembly/wasi-libc#391, that seem useful to have.
This change updates the `src/llvm-project` submodule to LLVM 16. While
experimenting with this, LLVM pre-released [rc2]. This commit uses that
release.

[rc2]: https://github.com/llvm/llvm-project/releases/tag/llvmorg-16.0.0-rc2
Due to [a change] in LLVM, Clang will expect to find the
`libclang_rt.builtins-wasm32.a` file in a path that only contains the
major version (`16`) instead of the entire version (`16.0.0`) as was
previously the case. This change modifies the `CMAKE_INSTALL_PREFIX` to
use Clang's major version only.

[a change]: https://reviews.llvm.org/D125860
@abrown abrown changed the title Pre-release wasi-sdk-20+threads Pre-release wasi-sdk-20+threads Feb 14, 2023
@abrown abrown mentioned this pull request Feb 14, 2023
@abrown
Copy link
Collaborator Author

abrown commented Apr 6, 2023

This no longer applies: #313 and #314 were merged and are now released in wasi-sdk-20.

@abrown abrown closed this Apr 6, 2023
@abrown abrown deleted the ci-threads-prerelease branch April 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant