Don't add git hash to version if minor==0 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a minor mistake from WebAssembly#392 where the previous perl script had a special case that if the "minor" version was zero then the git hash information wouldn't be printed.
abrown
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks for the fix! I should mention here for posterity, since I currently have this paged in: what I called "minor" here is actually not well-named, since I believe what git describe drops into this spot is actually "number of commits since last tag." I guess we'll run into issues if we ever decide to do an actual minor release like wasi-sdk-x.y; for now at least this will emulate what we have been doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor mistake from #392 where the previous perl script had a special case that if the "minor" version was zero then the git hash information wouldn't be printed.