Update build of toolchain/sysroot to not touch installation root #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes everything to ensure that only the `install` step actually tries to install things. Everything is staged into temporary `./install` folders inside of the build directory and then running the build system's `install` target will actually copy out everything using CMake builtins. Closes WebAssembly#442
yamt
added a commit
to yamt/wasi-libc
that referenced
this pull request
Jul 18, 2024
eg. when a user specifies non-default -resource-dir. cf. WebAssembly/wasi-sdk#446
alexcrichton
pushed a commit
to WebAssembly/wasi-libc
that referenced
this pull request
Jul 24, 2024
eg. when a user specifies non-default -resource-dir. cf. WebAssembly/wasi-sdk#446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes everything to ensure that only the
installstep actually tries to install things. Everything is staged into temporary./installfolders inside of the build directory and then running the build system'sinstalltarget will actually copy out everything using CMake builtins.Closes #442