Port some more wasmtime filesystem tests #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
reviewed
Sep 13, 2023
loganek
previously approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Please review all the temporary files/directories and use .cleanup suffix (see https://github.com/WebAssembly/wasi-testsuite/blob/main/doc/specification.md)
loganek
reviewed
Sep 13, 2023
loganek
reviewed
Sep 13, 2023
loganek
reviewed
Sep 13, 2023
loganek
reviewed
Sep 13, 2023
loganek
reviewed
Sep 13, 2023
zoraaver
force-pushed
the
port-more-tests
branch
from
249e1d9 to
0cfaaea
Compare
loganek
reviewed
Sep 13, 2023
zoraaver
force-pushed
the
port-more-tests
branch
2 times, most recently
from
6c4ec48 to
d6b984b
Compare
loganek
reviewed
Sep 14, 2023
To close the testing gaps on any filesystem functions, port some more of the wasmtime tests. A few test cases in dir_fd_op_failures seemed to be specific to wasmtime; namely fd_sync, fd_datasync, fd_fdstat_set_flags and fd_advise. These functions return errors when called on a directory fd on wasmtime but on WAMR (and POSIX) they return 0 so for the moment have removed them.
zoraaver
force-pushed
the
port-more-tests
branch
from
d6b984b to
017d232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close the testing gaps on any filesystem functions, port some more of the wasmtime tests. A few test cases in dir_fd_op_failures seemed to be specific to wasmtime; namely fd_sync, fd_datasync, fd_fdstat_set_flags and fd_advise. These functions return errors when called on a directory fd on wasmtime but on WAMR (and POSIX) they return 0 so for the moment have removed them.