Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change module name to wasi_snapshot_preview1 #47

Open
codefromthecrypt opened this issue Jul 13, 2023 · 2 comments
Open

change module name to wasi_snapshot_preview1 #47

codefromthecrypt opened this issue Jul 13, 2023 · 2 comments

Comments

@codefromthecrypt
Copy link

codefromthecrypt commented Jul 13, 2023

I came across below from rust-lang making a triple wasm32-wasi-preview1-threads

That's not right, wasi-threads is an extension to the Wasi Preview 1 specification which adds support for threads. That rationale was been clearly described in the rust-lang/compiler-team#574. The only thing that's changed since is that rust-lang/compiler-team#607 has been accepted, but that doesn't change the relationship between the base target and the threads extension. Since the compiler team has already accepted that rationale, it doesn't seem particularly productive to relitigate that in this PR

I am probably wrong, but I interpreted this as wasi-threads being an extension like the socket ABIs (sock_accept etc), which was added after the fact to wasi_snapshot_preview1. Can you clarify the position on this. Particularly, if this is a part of the wasi_snapshot_preview1 or not, and if this is intentionally in witx or will be converted to component model?

@codefromthecrypt
Copy link
Author

I'll track this personally as I was unaware of this being targeted for preview1 and I'm sure others are unaware also

@codefromthecrypt
Copy link
Author

apologies @yoshuawuyts for putting words in your mouth. I re-did the description to quote instead of summarize. I am actually confused and I believe this spec can clarify its intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant