Rename `wasm32-wasi` target to `wasm32-wasi-preview1` #607

yoshuawuyts · 2023-04-03T14:14:36Z

Proposal

This is a sibling MCP to: "New tier-2 target for wasm32-wasi-preview2" MCP. During the conversation on Zulip it came up that if we're going to be introducing wasm32-wasi-preview2, we should probably also rename the existing wasm32-wasi target to wasm32-wasi-preview1 in order to accurately set expectations. This is because eventually we'll want to deprecate the preview1 target, so it's probably best if we start communicating that in the name. Additionally we would also rename the wasm32-wasi-threads target to wasm32-wasi-preview1-threads.

Because we are not (yet) removing a target but only renaming it, we should be able to do this over a regular Rust release. This means we are not going to have a period where thewasm32-wasi and wasm32-wasi-preview1 targets are both available in the toolchain. In order to facilitate a smoother transition however, we may want to look into teaching the toolchain manager about "deprecated targets", so a better error can be issued for people looking to upgrade to a new Rust version where a target has been renamed or removed.

Mentors or Reviewers

N/A

Process

The main points of the Major Change Process are as follows:

File an issue describing the proposal.
A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
- Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

The text was updated successfully, but these errors were encountered:

rustbot · 2023-04-03T14:14:38Z

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

wesleywiser · 2023-04-05T16:08:18Z

@rustbot second

apiraino · 2023-04-17T10:30:31Z

@rustbot label -final-comment-period +major-change-accepted

Rename `wasm32-wasi` to `wasm32-wasi-preview1` Implements rust-lang/compiler-team#607

This commit adds a new target called `wasm32-wasi-preview1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasi-preview1` to better live alongside the [new `wasm32-wasi-preview2` target](rust-lang#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasi-preview1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

…ame, r=wesleywiser Add a new `wasm32-wasip1` target to rustc This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

…e, r=wesleywiser Add a new `wasm32-wasip1` target to rustc This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

…e, r=wesleywiser Add a new `wasm32-wasip1` target to rustc This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

…eywiser Add a new `wasm32-wasip1` target to rustc This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang/rust#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

…system WASI community is going to be introducing pN suffix to the target triples to distinguish the different versions of the WASI Preview versions (e.g. `wasm32-unknown-wasip1` for WASI Preview1) to prepare the upcoming WASI Preview2 and so on. Other projects are also following this change: * WebAssembly/wasi-libc#478 * rust-lang/compiler-team#607

…eywiser Add a new `wasm32-wasip1` target to rustc This commit adds a new target called `wasm32-wasip1` to rustc. This new target is explained in these two MCPs: * rust-lang/compiler-team#607 * rust-lang/compiler-team#695 In short, the previous `wasm32-wasi` target is going to be renamed to `wasm32-wasip1` to better live alongside the [new `wasm32-wasip2` target](rust-lang/rust#119616). This new target is added alongside the `wasm32-wasi` target and has the exact same definition as the previous target. This PR is effectively a rename of `wasm32-wasi` to `wasm32-wasip1`. Note, however, that as explained in rust-lang/compiler-team#695 the previous `wasm32-wasi` target is not being removed at this time. This change will reach stable Rust before even a warning about the rename will be printed. At this time this change is just the start where a new target is introduced and users can start migrating if they support only Nightly for example.

This commit is a continuation of the work originally proposed in rust-lang/compiler-team#607 and later amended in rust-lang/compiler-team#695. The end goal is to rename `wasm32-wasi` to `wasm32-wasip1` to reflect WASI's development and distinguish the preexisting target from the `wasm32-wasip2` target that WASI is now developing. Work for this transition began in rust-lang#120468 which landed in Rust 1.78 which became stable on 2024-05-02. This implements the next phase of the transition plan to warn on usage of `wasm32-wasi`. This is intended to help alert users that a removal is pending and all release channels have the replacement available as well. This will reach stable on 2024-09-05. The next stage of the plan is to remove the `wasm32-wasi` target some time in October 2024 which means that the removal will reach stable on 2025-01-09. For reference a full schedule of this transition is listed [here]. Currently this implementation is a simple unconditional warning whenever `rustc --target wasm32-wasi` is invoked. As-implemented there's no way to turn off the warning other than to switch to the `wasm32-wasip1` target. [here]: rust-lang#120468 (comment)

…r=michaelwoerister Unconditionally warn on usage of `wasm32-wasi` This commit is a continuation of the work originally proposed in rust-lang/compiler-team#607 and later amended in rust-lang/compiler-team#695. The end goal is to rename `wasm32-wasi` to `wasm32-wasip1` to reflect WASI's development and distinguish the preexisting target from the `wasm32-wasip2` target that WASI is now developing. Work for this transition began in rust-lang#120468 which landed in Rust 1.78 which became stable on 2024-05-02. This implements the next phase of the transition plan to warn on usage of `wasm32-wasi`. This is intended to help alert users that a removal is pending and all release channels have the replacement available as well. This will reach stable on 2024-09-05. The next stage of the plan is to remove the `wasm32-wasi` target some time in October 2024 which means that the removal will reach stable on 2025-01-09. For reference a full schedule of this transition is listed [here]. Currently this implementation is a simple unconditional warning whenever `rustc --target wasm32-wasi` is invoked. As-implemented there's no way to turn off the warning other than to switch to the `wasm32-wasip1` target. [here]: rust-lang#120468 (comment)

Rollup merge of rust-lang#126662 - alexcrichton:warn-on-wasm32-wasi, r=michaelwoerister Unconditionally warn on usage of `wasm32-wasi` This commit is a continuation of the work originally proposed in rust-lang/compiler-team#607 and later amended in rust-lang/compiler-team#695. The end goal is to rename `wasm32-wasi` to `wasm32-wasip1` to reflect WASI's development and distinguish the preexisting target from the `wasm32-wasip2` target that WASI is now developing. Work for this transition began in rust-lang#120468 which landed in Rust 1.78 which became stable on 2024-05-02. This implements the next phase of the transition plan to warn on usage of `wasm32-wasi`. This is intended to help alert users that a removal is pending and all release channels have the replacement available as well. This will reach stable on 2024-09-05. The next stage of the plan is to remove the `wasm32-wasi` target some time in October 2024 which means that the removal will reach stable on 2025-01-09. For reference a full schedule of this transition is listed [here]. Currently this implementation is a simple unconditional warning whenever `rustc --target wasm32-wasi` is invoked. As-implemented there's no way to turn off the warning other than to switch to the `wasm32-wasip1` target. [here]: rust-lang#120468 (comment)

…woerister Unconditionally warn on usage of `wasm32-wasi` This commit is a continuation of the work originally proposed in rust-lang/compiler-team#607 and later amended in rust-lang/compiler-team#695. The end goal is to rename `wasm32-wasi` to `wasm32-wasip1` to reflect WASI's development and distinguish the preexisting target from the `wasm32-wasip2` target that WASI is now developing. Work for this transition began in #120468 which landed in Rust 1.78 which became stable on 2024-05-02. This implements the next phase of the transition plan to warn on usage of `wasm32-wasi`. This is intended to help alert users that a removal is pending and all release channels have the replacement available as well. This will reach stable on 2024-09-05. The next stage of the plan is to remove the `wasm32-wasi` target some time in October 2024 which means that the removal will reach stable on 2025-01-09. For reference a full schedule of this transition is listed [here]. Currently this implementation is a simple unconditional warning whenever `rustc --target wasm32-wasi` is invoked. As-implemented there's no way to turn off the warning other than to switch to the `wasm32-wasip1` target. [here]: rust-lang/rust#120468 (comment)

This commit is the final step in the journey of renaming the historical `wasm32-wasi` target in the Rust compiler to `wasm32-wasip1`. Various steps in this journey so far have been: * 2023-04-03: rust-lang/compiler-team#607 - initial proposal for this rename * 2024-11-27: rust-lang/compiler-team#695 - amended schedule/procedure for rename * 2024-01-29: rust-lang#120468 - initial introduction of `wasm32-wasip1` * 2024-06-18: rust-lang#126662 - warn on usage of `wasm32-wasi` * 2024-11-08: this PR - remove the `wasm32-wasi` target The full transition schedule is in [this comment][comment] and is summarized with: * 2024-05-02: Rust 1.78 released with `wasm32-wasip1` target * 2024-09-05: Rust 1.81 released warning on usage of `wasm32-wasi` * 2025-01-09: Rust 1.84 to be released without the `wasm32-wasi` target This means that support on stable for the replacement target of `wasm32-wasip1` has currently been available for 6 months. Users have already seen warnings on stable for 2 months about usage of `wasm32-wasi` and stable users have another 2 months of warnings before the target is removed from stable. This commit is intended to be the final step in this transition so the source tree should no longer mention `wasm32-wasi` except in historical reference to the older name of the `wasm32-wasip1` target. [comment]: rust-lang#120468 (comment)

yoshuawuyts added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Apr 3, 2023

rustbot added the to-announce Announce this issue on triage meeting label Apr 3, 2023

rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Apr 5, 2023

apiraino removed the to-announce Announce this issue on triage meeting label Apr 6, 2023

rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Apr 17, 2023

yoshuawuyts closed this as completed Apr 20, 2023

yoshuawuyts mentioned this issue Apr 20, 2023

Rename wasm32-wasi to wasm32-wasi-preview1 rust-lang/rust#110596

Closed

apiraino removed the to-announce Announce this issue on triage meeting label Apr 20, 2023

This was referenced Apr 21, 2023

Rename wasm32-wasi to wasm32-wasi-preview1 rust-lang/stdarch#1417

Closed

Rename wasm32-wasi to wasm32-wasip1 rust-lang/rustc-dev-guide#1678

Merged

Renaming the WASI target in Rust 1.71.0 rust-lang/blog.rust-lang.org#1099

Closed

the8472 mentioned this issue Jun 28, 2023

Add support for the riscv64-linux-android target #640

Closed

3 tasks

deltragon mentioned this issue Jun 29, 2023

WASI threads, implementation of wasm32-wasi-preview1-threads target rust-lang/rust#112922

Merged

yoshuawuyts mentioned this issue Jul 5, 2023

Tracking Issue for Compiler MCP 607: Rename wasm32-wasi target to wasm32-wasi-preview1 rust-lang/rust#113364

Open

7 tasks

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 5, 2023

Auto merge of rust-lang#110596 - yoshuawuyts:rename-wasm32-wasi, r=<try>

4583ef2

Rename `wasm32-wasi` to `wasm32-wasi-preview1` Implements rust-lang/compiler-team#607

vados-cosmonic mentioned this issue Jul 6, 2023

feat: add preview2 target to wasmcloud.toml wasmCloud/wash#641

Merged

10 tasks

codefromthecrypt mentioned this issue Jul 13, 2023

change module name to wasi_snapshot_preview1 WebAssembly/wasi-threads#47

Open

pnkfelix mentioned this issue Jul 13, 2023

Update Android system definitions and add riscv-linux-android as tier 3 target rust-lang/rust#112858

Merged

alexcrichton mentioned this issue Nov 27, 2023

Smooth the renaming transition of wasm32-wasi #695

Closed

3 tasks

alexcrichton mentioned this issue Jan 29, 2024

Add a new wasm32-wasip1 target to rustc rust-lang/rust#120468

Merged

alexcrichton mentioned this issue Feb 20, 2024

Add a new wasm32-wasip2 target rust-lang/rust#119616

Merged

kateinoigakukun mentioned this issue Mar 28, 2024

Rename wasm32-unknown-wasi to wasm32-unknown-wasip1 in the build system ruby/ruby.wasm#415

Merged

alexcrichton mentioned this issue Jun 19, 2024

Unconditionally warn on usage of wasm32-wasi rust-lang/rust#126662

Merged

alyssais mentioned this issue Jul 4, 2024

rust: make pkgsCross.wasi32.rustPlatform.buildRustPackage work NixOS/nixpkgs#323161

Draft

13 tasks

Rjected mentioned this issue Jul 17, 2024

fix: Added CI back for check_no_std with compilation to wasm32 paradigmxyz/reth#9347

Closed

alexcrichton mentioned this issue Nov 3, 2024

Remove the wasm32-wasi target from rustc rust-lang/rust#132562

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `wasm32-wasi` target to `wasm32-wasi-preview1` #607

Rename `wasm32-wasi` target to `wasm32-wasi-preview1` #607

yoshuawuyts commented Apr 3, 2023 •

edited

Loading

rustbot commented Apr 3, 2023

wesleywiser commented Apr 5, 2023

apiraino commented Apr 17, 2023

Rename wasm32-wasi target to wasm32-wasi-preview1 #607

Rename wasm32-wasi target to wasm32-wasi-preview1 #607

Comments

yoshuawuyts commented Apr 3, 2023 • edited Loading

Proposal

Mentors or Reviewers

Process

Comments

rustbot commented Apr 3, 2023

wesleywiser commented Apr 5, 2023

apiraino commented Apr 17, 2023

Rename `wasm32-wasi` target to `wasm32-wasi-preview1` #607

Rename `wasm32-wasi` target to `wasm32-wasi-preview1` #607

yoshuawuyts commented Apr 3, 2023 •

edited

Loading