chore: update interop test run condition #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interop tests are run as expected, even though |
jxs
reviewed
Sep 30, 2024
guillaumemichel
force-pushed
the
interop-checks
branch
from
6802a0e
to
4868d77
Compare
|
Sure, reverted the indentation 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #5604. Interop tests only work on the main
rust-libp2prepo, and not on forks, because of the S3 cache (introduced in #5586).The interop tests currently don't run in the PRs, but they run after the PRs are merged to
master. This PR is trying to run interop tests in PR that are branches of the main repo (not forks).