chore: identify::Config fields private

[kamuik16]

Description

Closes #5660

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[jxs]

Thanks for getting this started! We should also define the setter methods, increment the version on Cargo.toml and introduce the change on CHANGELOG.md

[kamuik16]

Thanks for getting this started! We should also define the setter methods, increment the version on Cargo.toml and introduce the change on CHANGELOG.md

For setters do you think all the with_* methods that already exists are enough?

[jxs]

For setters do you think all the with_* methods that already exists are enough?

ah! Good point, I wasn't aware they already existed, yeah makes sense

[kamuik16]

Thanks for getting this started! We should also define the setter methods, increment the version on Cargo.toml and introduce the change on CHANGELOG.md

Incremented the version in Cargo.toml and updated CHANGELOG.md accordingly.

[kamuik16]

semver check is failing because it require a major version update rather than a minor one. any thoughts?

[stormshield-frb]

Hi @kamuik16. You can bump to 0.46.0. We discussed it with @jxs yesterday. This PR relates to this comment #5574 (comment).

[stormshield-frb]

Left some minor comments about the return value of some getters. It is good practices to return only a reference (in a getter function) if the type is not Copy. It avoids cloning when not required.

[jxs]

LGTM Thanks!